Skip to content

docs: fix grammar and typos in code comments - #70

Open
Avicennasis wants to merge 1 commit into
appfolio:masterfrom
TypoScan3000:docs/fix-typos
Open

Avicennasis wants to merge 1 commit into
appfolio:masterfrom
TypoScan3000:docs/fix-typos

Conversation

@Avicennasis

Copy link
Copy Markdown

Summary

Fix grammar and typos in code comments across 3 files:

  • lib/declarative_authorization/maintenance.rb
    • L9: maintenance operation at → maintenance operations at
    • L144: Analogue to the Ruby's → Analogue to Ruby's
    • L161: the objects class name → the object's class name
    • L164: If you use specify → If you specify
  • lib/declarative_authorization/controller/runtime.rb
    • L10: measures in place that restricts → that restrict
    • L62: Works similar to → Works similarly to
  • lib/declarative_authorization/in_model.rb
    • L21: Works similar to → Works similarly to
    • L110: a Authorization::AuthorizationError → an Authorization::AuthorizationError
    • L118: the models table name → the model's table name

No functional changes — comments/documentation only.

@Avicennasis
Avicennasis requested a review from a team as a code owner October 24, 2026 05:45
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
@Avicennasis

Copy link
Copy Markdown
Author

Heads up on the two blockers here:

  1. Signed commits — the commit has been re-created with a GPG signature (65cd7b6), verified by GitHub. Same change, same message, single commit.

  2. lint-commits red X — this looks like an upstream workflow issue with fork PRs, not a problem with the commit content. The reusable workflow (appfolio/rubygems-releaser lint-commits.yml@v1) checks out github.head_ref (docs/fix-typos) from the base repository, where that branch doesn't exist — the git fetch +refs/heads/docs/fix-typos* step fails (exit 1, three retries, then the job fails). The commit message passes commitlint when run locally. Happy to adjust the message if you're seeing something different on your side.

Also fixed our local setup so future PRs from us arrive pre-signed. Thanks for the approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants